Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): Handle medusa service base methods events #9179

Merged
merged 12 commits into from
Sep 18, 2024

Conversation

adrien2p
Copy link
Member

What
Properly handle medusa service event for non overridden methods. Also, provide useful utils to centralise event name building as well as message aggregation with inference from the medusa service itself. Accessible from derived service.

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 2:36pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 18, 2024 2:36pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 2:36pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 2:36pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 2:36pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 2:36pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 2:36pm

Copy link

changeset-bot bot commented Sep 18, 2024

⚠️ No Changeset found

Latest commit: f3220f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review September 18, 2024 14:35
@adrien2p adrien2p requested a review from a team as a code owner September 18, 2024 14:35
@adrien2p
Copy link
Member Author

@olivermrbl do you want to throw an eye?

@adrien2p adrien2p merged commit a734184 into develop Sep 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants