docs: updates to digital product recipe #9165
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
| ] | ||
| 1. Retrieve the digital product order's details. For this, you'll use the `useRemoteQueryStep` imported from `@medusajs/core-flows`. | ||
| 2. Send a notification to the customer with the digital products to download. | ||
| 3. Create a shipment for the fulfillment to indicate that the item is fulfilled. For this step, you'll use from the `@medusajs/core-flows` package the `createOrderShipmentWorkflow` as a step. |
There was a problem hiding this comment.
thought: I think we should consider removing the third step here. Digital products are not shipped and should ideally be created with a requires_shipping: false option, which can be used in the storefront to build the appropriate checkout flow. The item processing flow for digital products should end after fulfillment.
There was a problem hiding this comment.
@olivermrbl ah makes sense, where would requires_shipping: false be passed? when the shipping method is set on the cart?
There was a problem hiding this comment.
I just checked and that's the property of an inventory item, but digital products don't have inventory items (unless that's the better approach?)
There was a problem hiding this comment.
but digital products don't have inventory items
Hmm, I guess that depends on the case. For example, you might have a limited amount of licenses. Conversely, it is also very likely that you have an unlimited amount of licenses 😄
For the recipe, my take would be that we should not have the shipment step. This is likely also how we will build the digital products starter (when we get around to it).
|
Was the recipe changed otherwise? Was having an issue when uploading, had to add multer on the api path for upload. Now i'm having an issue with type CreateRequestBody = z.infer<typeof createDigitalProductsSchema>;
export const POST = async (
req: AuthenticatedMedusaRequest<CreateRequestBody>,
res: MedusaResponse
) => {
const { result } = await createDigitalProductWorkflow(req.scope).run({
input: {
digital_product: {
name: req.validatedBody.name,
medias: req.validatedBody.medias.map((media) => ({
fileId: media.file_id,
mimeType: media.mime_type,
...media,
})) as Omit<CreateDigitalProductMediaInput, "digital_product_id">[],
},
product: req.validatedBody.product,
},
});
res.json({
digital_product: result.digital_product,
});
};Not sure why middleware.ts wasn't applying the multer, but Modified api to use multer, now uploads work, but it dies on verificationBody as mentioned above import multer from "multer";
import { AuthenticatedMedusaRequest, MedusaResponse } from "@medusajs/medusa";
import { uploadFilesWorkflow } from "@medusajs/core-flows";
import { MedusaError } from "@medusajs/utils";
const upload = multer({ storage: multer.memoryStorage() });
export const uploadMiddleware = upload.array("files");
export const POST = async (
req: AuthenticatedMedusaRequest,
res: MedusaResponse
) => {
uploadMiddleware(req as any, res as any, async (err: any) => {
if (err) {
console.error("Error handling file upload:", err);
return res.status(500).json({ error: "File upload failed" });
}
const access = req.params.type === "main" ? "private" : "public";
const input = req.files as Express.Multer.File[];
if (!input?.length) {
throw new MedusaError(
MedusaError.Types.INVALID_DATA,
"No files were uploaded"
);
}
const { result } = await uploadFilesWorkflow(req.scope).run({
input: {
files: input?.map((f) => ({
filename: f.originalname,
mimeType: f.mimetype,
content: f.buffer.toString("binary"),
access,
})),
},
});
res.status(200).json({ files: result });
});
}; |
@420coupe This is already part of the recipe.
there was an issue with middlewares in a preview version we released yesterday. Can you update and try again? |
Tyvm, been chasing my tail all day trying to figure out why. found another small bug, when deleting a digital product from the product section, it doesn't delete the digital product and then causes an error when going to digital products on adminui |
|
also you never attach the digital product in the notification. |
@420coupe We instead retrieve the URLs of all digital products and pass them in the notification's payload. You're free to do it differently if that's your use case. |
digital_product_order.createdevent to use the workflow