Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(index): Index module foundation #9095

Merged
merged 32 commits into from
Sep 18, 2024
Merged

feat(index): Index module foundation #9095

merged 32 commits into from
Sep 18, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Sep 11, 2024 •
edited by carlos-r-l-rodrigues
Loading

What
Index module foundation

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:46pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:46pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 6:46pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 6:46pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 6:46pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 6:46pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 6:46pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 657e886

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carlos-r-l-rodrigues carlos-r-l-rodrigues changed the title feat(index): Initial commit feat(index): Index module foundation Sep 17, 2024
@carlos-r-l-rodrigues carlos-r-l-rodrigues marked this pull request as ready for review September 18, 2024 17:19
olivermrbl
olivermrbl approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monumental

integration-tests/modules/package.json Outdated Show resolved Hide resolved
packages/modules/index/src/models/index-data.ts
@@ -0,0 +1,45 @@
import {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Are we missing something in the DML to use this here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gin index perhaps?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GIN index and an autoincrement column

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this was missing but we tried DML first ahah

@kodiakhq kodiakhq bot merged commit 58167b5 into develop Sep 18, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/index-engine-revive branch September 18, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrien2p @carlos-r-l-rodrigues @olivermrbl