Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang and tools version for new language idioms #223

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

arkadiuszos4chain
Copy link
Contributor

This update addresses compatibility issues with newer Go language idioms. The current version of moq fails when encountering certain statements, such as:

for range 5 {
  // ...
}

which results in the following error:

couldn't load source package: sample.go:110:12: cannot range over 5 (untyped int constant)

##Changes:

  • Go version: Bumped from 1.18 to 1.22.5
  • golang.org/x/tools: Updated from 0.17.0 to 0.24.0
  • Replaced usage of deprecated ioutils

@ns-skaranth
Copy link

@arkadiuszos4chain could you add a test case that has some of the new constructs in the source somewhere?

@arkadiuszos4chain
Copy link
Contributor Author

@arkadiuszos4chain could you add a test case that has some of the new constructs in the source somewhere?

@ns-skaranth I'm not sure if I choose best place, but you can check my test case.

Copy link
Collaborator

@sudo-suhas sudo-suhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudo-suhas
Copy link
Collaborator

@arkadiuszos4chain could you rebase the PR on the master branch? There were some changes made to run tests on the latest stable version

@arkadiuszos4chain
Copy link
Contributor Author

@arkadiuszos4chain could you rebase the PR on the master branch? There were some changes made to run tests on the latest stable version

@sudo-suhas done.

@sudo-suhas sudo-suhas merged commit efa43c6 into matryer:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants