Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exploring multiselect possibilities #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahume
Copy link

@ahume ahume commented Nov 22, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2020

CLA assistant check
All committers have signed the CLA.

Copy link

@xxmyjk xxmyjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And better use readline.Char* instead of hardcode.

@@ -235,3 +237,20 @@ func (l *List) Items() ([]interface{}, int) {

return result, active
}

func (l *List) Select() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://travis-ci.org/github/manifoldco/promptui/jobs/745229020#L234

list/list.go:241:1: exported method `List.Select` should have comment or be unexported (golint)

}
}

func (l *List) Selected() []int {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://travis-ci.org/github/manifoldco/promptui/jobs/745229020#L237

list/list.go:249:1: exported method `List.Selected` should have comment or be unexported (golint)

HideHelp bool
}

func (ms *MultiSelect) Run() ([]int, []string, error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://travis-ci.org/github/manifoldco/promptui/jobs/745229020#L240

select.go:690:1: exported method `MultiSelect.Run` should have comment or be unexported (golint)

Copy link

@xxmyjk xxmyjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. make a Select prompt
  2. do up/down step util new page of size
  3. Enter to select
  4. cause out of range error

Seems new innerRun logic broken old Select behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants