-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow unknown function calls to specify an expression type #1618
Open
christopherswenson
wants to merge
12
commits into
main
Choose a base branch
from
crs-unknown-function-expression-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure about |
christopherswenson
changed the title
WIP allow unknown function calls to specify an expression type
Allow unknown function calls to specify an expression type
Feb 8, 2024
…ause it can't do a typed bag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new syntax:
function_name!number!measure(...)
to mark that the function should be treated as an aggregate expression, including handling distinct keys for joinsjoin1.join2.function_name!number!measure(...)
join1.join2.field1.function_name!number!measure(...)
field1.function_name!number!measure(...)
function_name!number!calculation(...)
to mark that the function should be treated as an analytic function, including adding anOVER (...)
clause afterward, and support for{ partition_by: ..., order_by: ... }
function_name!number!dimension(...)
is the same asfunction_name!number(...)
but more explicitThis all requires the
##! experimental.unknown_function_expression_types
experiment to be enabled.