Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unknown function calls to specify an expression type #1618

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

christopherswenson
Copy link
Contributor

@christopherswenson christopherswenson commented Feb 7, 2024

Adds new syntax:

  • function_name!number!measure(...) to mark that the function should be treated as an aggregate expression, including handling distinct keys for joins
  • join1.join2.function_name!number!measure(...)
  • join1.join2.field1.function_name!number!measure(...)
  • field1.function_name!number!measure(...)
  • function_name!number!calculation(...) to mark that the function should be treated as an analytic function, including adding an OVER (...) clause afterward, and support for { partition_by: ..., order_by: ... }
  • function_name!number!dimension(...) is the same as function_name!number(...) but more explicit

This all requires the ##! experimental.unknown_function_expression_types experiment to be enabled.

@christopherswenson
Copy link
Contributor Author

Not sure about measure/calculation vs aggregate/analytic...

@christopherswenson christopherswenson marked this pull request as ready for review February 8, 2024 15:48
@christopherswenson christopherswenson changed the title WIP allow unknown function calls to specify an expression type Allow unknown function calls to specify an expression type Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant