Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new paseo runtime #3013

Merged
merged 33 commits into from
Sep 16, 2024
Merged

feat: add new paseo runtime #3013

merged 33 commits into from
Sep 16, 2024

Conversation

felixfaisal
Copy link
Member

This PR is ready to be reviewed, Meanwhile I will be resolving conflicts and check the CI.

@felixfaisal felixfaisal requested review from Kailai-Wang, silva-fj and a team August 26, 2024 04:41
Copy link

linear bot commented Aug 26, 2024

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's a fresh new runtime, right?
The paseo chain will start from block #0 with genesis state?

Makefile Outdated Show resolved Hide resolved
docker/paseo-parachain-launch-config.yml Outdated Show resolved Hide resolved
docker/paseo-parachain-launch-config.yml Outdated Show resolved Hide resolved
node/res/genesis_info/paseo.json Outdated Show resolved Hide resolved
node/src/chain_specs/paseo.rs Outdated Show resolved Hide resolved
node/src/command.rs Outdated Show resolved Hide resolved
runtime/paseo/src/migration/P9100.rs Outdated Show resolved Hide resolved
scripts/launch-local-binary.sh Outdated Show resolved Hide resolved
@BillyWooo
Copy link
Collaborator

There are still quite many new changes containing "rococo" text. They need to be adapted, as well as the conflicts.

@@ -83,6 +83,7 @@ mod constants {

pub const LITENTRY_PARA_ID: u32 = 2013;
pub const ROCOCO_PARA_ID: u32 = 2106; // will be replaced by paseo
pub const PASEO_PARA_ID: u32 = 2106; // will be replaced by paseo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"2106" will remain same? So once paseo is merged into dev, rococo needs to be removed immediately, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware about the strategy for removing rococo, So I can't really comment on that.

docker/paseo-parachain-launch-config.yml Outdated Show resolved Hide resolved
@BillyWooo BillyWooo merged commit aaa81cf into dev Sep 16, 2024
28 checks passed
@BillyWooo BillyWooo deleted the p-884-integrate-with-passeo branch September 16, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants