fix(autonat): reject inbound dial request from peer if its not connected #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eligioo
force-pushed
the
fix/autonat-reject-peer-dial
branch
from
92cd0cf
to
40b55f4
Compare
Eligioo
changed the title
dariusc93
changed the title
dariusc93
changed the title
dariusc93
reviewed
Sep 12, 2024
Eligioo
force-pushed
the
fix/autonat-reject-peer-dial
branch
from
40b55f4
to
e749ffe
Compare
|
@dariusc93 thanks for the review. Addressed the comments. |
jxs
approved these changes
Sep 13, 2024
dariusc93
reviewed
Sep 13, 2024
Eligioo
force-pushed
the
fix/autonat-reject-peer-dial
branch
from
e749ffe
to
665d6a6
Compare
dariusc93
approved these changes
Sep 13, 2024
|
Thanks @Eligioo! |
|
@dariusc93 fixed the workspace Might be a small improvement to inform external contributors to also bump the various |
Thanks! We do try to if its needed and CI will inform us if they need to be updated as well :) |
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
…ted (libp2p#5597) ## Description As discovered and described in the issue below, there are situations where an incoming AutoNAT dial can come from a non-connected peer. However `resolve_inbound_request` expects that this situation cannot occur. This PR adds a check upfront and refuses the incoming dial when no connected peer is found. Fixes libp2p#5570. ## Change checklist - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [x] A changelog entry has been made in the appropriate crates Co-authored-by: João Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discovered and described in the issue below, there are situations where an incoming AutoNAT dial can come from a non-connected peer. However
resolve_inbound_requestexpects that this situation cannot occur. This PR adds a check upfront and refuses the incoming dial when no connected peer is found.Fixes #5570.
Change checklist