feat(SwarmBuilder): add with_connection_timeout method #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormshield-frb
force-pushed
the
feat/add-connection-timeout-to-swarm-builder
branch
from
df78e2c
to
f78ea9d
Compare
stormshield-frb
force-pushed
the
feat/add-connection-timeout-to-swarm-builder
branch
from
f78ea9d
to
1300365
Compare
dariusc93
reviewed
Sep 5, 2024
Comment on lines
+17
to
+18
| #[allow(unused)] // used in `../swarm.rs` but due to feature flag combinations, clippy gives an unnecessary warning. | ||
| pub(crate) const DEFAULT_CONNECTION_TIMEOUT: Duration = Duration::from_secs(10); |
There was a problem hiding this comment.
the old constant was used in this same file, but it isn't anymore. I think it would be clearer to move it to ../swarm.rs where most items have similar allow annotations and where the new constant is actually used, thus removing the need to comment about a different file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small PR to be able to change the
connection_timeoutvalue given to theTransportTimeoutwhen building theSwarmwith aSwarmBuilder.Notes & open questions
Change checklist