Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libp2p-swarm-test): Support tokio #5489

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ark0f
Copy link

@ark0f ark0f commented Jul 9, 2024

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks for this! Features should be additive, so if we wanted to support both executors we should namespace them. But following #4449 I'd say we can just replace async-std for tokio, wdyt?
cc @dariusc93 @guillaumemichel

@guillaumemichel
Copy link
Contributor

I agree with @jxs, IMO async-std should be replaced by tokio.

@dariusc93
Copy link
Member

dariusc93 commented Aug 27, 2024

I do agree with the idea of replacing async-std with tokio as well. Maybe start with the tests and following #4449 we can move on to preferring tokio in other parts of rust-libp2p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants