Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitLab #1143

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Migrate to GitLab #1143

wants to merge 4 commits into from

Conversation

jorgesumle
Copy link
Contributor

Addresses #46

I considered that issue, labels and raw file URLs change, so I adapted them accordingly. However, the URL for graph statistics from robots.txt doesn't work on GitLab, you cannot select a time period, so I simplified it, and I remove the mention to Gratipay and that time distinction, since they are Liberapay contributors anyway.

The GitHub logo from the footer was changed as well.

screenshot at 2018-06-14 12 04 09

One note: There was a translatable string that mentioned GitHub, so I executed find . -type f -print0 | xargs -0 sed -i 's/GitHub/GitLab/g'. Some languages (Czech and Polish) change nouns based on cases, and I'm not sure about their rules, so I did the best I could and marked those as fuzzy.

@jorgesumle
Copy link
Contributor Author

jorgesumle commented Jun 14, 2018

There are some things we should do:

  • Replace references to GitHub with references to GitLab
  • Reconfigure Weblate to point to new repository
  • Replace Travis with GitLab-CI
  • Import salon, liberapay.org, payment-cards.js to GitLab
  • Reconfigure Sentry
  • Add GitLab group icon and description
  • ... (did I forget something?)

@jorgesumle
Copy link
Contributor Author

I need some help with GitLab-CI, for some reason PosgreSQL works for the ./recreate-schema.sh test, but doesn't work with tox. Is there an special way I should enter the posgres variables for Python programs? I added a commit with my progress, maybe it's a trivial fix I can't see.

@jorgesumle
Copy link
Contributor Author

jorgesumle commented Jun 21, 2018

@Changaco, can you help me with the remaining issues? I don't think I have the right permissions. Once we're done, we should review and merge this.

@jorgesumle jorgesumle changed the title WIP: Migrate to GitLab Migrate to GitLab Jun 21, 2018
@Changaco
Copy link
Member

I am not ready to move Liberapay to GitLab and I don't want to put any effort into this right now.

It's unlikely that I'll approve a migration to GitLab as long as liberapay.com doesn't support GitLab as well as it supports GitHub (see issues containing "GitLab" in the title).

@MartinDelille
Copy link
Contributor

Deleting .travis.yml block the process.

@jorgesumle
Copy link
Contributor Author

GitLab doesn't use Travis, so it's useless to keep it. It can still be tested locally. I'll add it again if deemed necessary when we decide it's time to solve this issue.

@MartinDelille
Copy link
Contributor

Yes but add gitlab support should not degrade github support which need the .travis.yml file to validate the pull request. Could you please revert your deletion?

Copy link
Contributor

@MartinDelille MartinDelille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gitlab migration shouldn't avoid github user to contribute. I'm wondering if it is possible to manage a project on both gitlab and github. Theorically yes, but practically this would increase the maintainer work and putting the information in two separated place.

.travis.yml Outdated
sudo: false
dist: trusty
git:
strategy: tarball
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore .travis.yml

@MartinDelille
Copy link
Contributor

I think this branch could be merged if:

  • the conflict are fixed
  • it should be clear that github stay the official repository
  • gitlab is added in the social media links

@@ -36,7 +36,7 @@ Note: This webapp is not self-hostable.

You want to chat? [Join us on Gitter](https://gitter.im/liberapay/salon). (If you use IRC, [Gitter has a gateway](https://irc.gitter.im/), and we're also in the #liberapay channel on Freenode.)

Alternatively you can post a message in [our GitHub salon](https://github.com/liberapay/salon).
Alternatively you can post a message in [our GitHub salon](https://gitlab.com/liberapay/salon).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Alternatively you can post a message in [our GitHub salon](https://gitlab.com/liberapay/salon).
Alternatively, you can post a message in [our GitLab salon](https://gitlab.com/liberapay/salon).

@antenore
Copy link

LiberaPay is meant for open source projects, and it should have a as much as possible open source friendly Git repository.

While GitLab it's not the perfect solution in terms of Freedom, GitHub it's the worst. It's mainly a question of image.

Consider the GitLab program for open source projects, you get all the tools you need for 0$/year

I'd wouldn't be extreme in removing GitHub, but keeping it as a mirror, just deactivating the issues and politely refusing PR on GitHub.

Doing it in small steps it's feasible and it's worth to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants