Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Added Components dropdown functionality, resolved small devices dropdown issues #5722

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Muhammed-Moinuddin
Copy link
Contributor

Description
Made Table of Content (button) and dropdown workable on small devices.
Added dropdown functionality to components.

This PR fixes #5694 #5677

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 24, 2024

🚀 Preview for commit c0059d0 at: https://66a0d372d54a9cf62f93852f--layer5.netlify.app

}`}
activeClassName="active"
>
Button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why they are static? Shouldn't they be dynamic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just followed the previous way of code (i.e. static). Dynamic would be great. I'll look into it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please propose a change if you would

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will.

@Ashparshp
Copy link
Contributor

@Muhammed-Moinuddin Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@Muhammed-Moinuddin
Copy link
Contributor Author

@Muhammed-Moinuddin Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

Not fruitful. I need to make changes in it.

@l5io
Copy link
Contributor

l5io commented Aug 11, 2024

🚀 Preview for commit be5170d at: https://66b8ccf5a3dcf17322b4843e--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 11, 2024

🚀 Preview for commit f2cbf60 at: https://66b915c1e24d819efd07976a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 11, 2024

🚀 Preview for commit 56ac93d at: https://66b924e1fdff58b4813d4342--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@Muhammed-Moinuddin, Thank you! Let's discuss this during the website call and get it merged. Please consider adding it as an agenda item to the meeting minutes || meeting link.

@sudhanshutech
Copy link
Member

@Muhammed-Moinuddin please resolve the merge conflicts. so we can move ahead.

@Ashparshp
Copy link
Contributor

@Muhammed-Moinuddin //

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Component of Sistent should have dropdown
4 participants