[rfc] langgraph: check if model passed as runnable binding with tools in create_react_agent #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinthornw
reviewed
Sep 6, 2024
| @@ -426,7 +465,9 @@ class Agent,Tools otherClass | |||
| else: | |||
| tool_classes = tools | |||
| tool_node = ToolNode(tool_classes) | |||
There was a problem hiding this comment.
Unrelated to this but thoughts on getting the tool_classes from the tool node here too so we can let you pass in raw functions ?
tool_classes = tools.tools_by_name.values()
There was a problem hiding this comment.
i think in tools_by_name it will also be a tool as we're calling create_tool under the hood https://github.com/langchain-ai/langgraph/blob/main/libs/langgraph/langgraph/prebuilt/tool_node.py#L95
There was a problem hiding this comment.
ahh nevermind, i misread first, yes, we can definitely do that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow users to customize models they pass to
create_react_agent, including enabling/disabling parallel tool calling on the model.If a model is passed as
RunnableBindingwith tools, we'll validate that the tools match the list of tools increate_react_agentand use the bound tools instead of binding insidecreate_react_agent