Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agenda.md to include Roave/BackwardCompatibilityCheck in laminas builds #160

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

Slamdunk
Copy link
Contributor

I always assumed it was already part of the build, and I almost released an unwanted BC Break for that:

laminas/laminas-form#248 (review)

Signed-off-by: Filippo Tessarotto <[email protected]>
@Slamdunk Slamdunk changed the title Update agenda.md Update agenda.md to include Roave/BackwardCompatibilityCheck in laminas builds Nov 29, 2023
@weierophinney weierophinney merged commit c840943 into laminas:main Dec 4, 2023
1 check passed
@Slamdunk Slamdunk deleted the patch-1 branch December 4, 2023 17:27
@boesing
Copy link
Member

boesing commented Dec 4, 2023

FYI: It is available if you enable the scan via configuration. Add backwardCompatibilityCheck with true via .laminas-ci.json file.

I wanted it to be opt-in to prevent having weird surprises in 3rd-party upstream.
Since we already worked on a v2 of the container where old PHP versions were dropped as well, I thought having that flag being enabled by-default in v2 makes sense.

Maybe it makes sense to have the matrix action to assume it as true for all mezzio/*, laminas-api-tools/* and lamians/* projects by default.

I've also created 3 issues regarding the backwards compatibility feature in the CI matrix:
laminas/laminas-ci-matrix-action#288
laminas/laminas-ci-matrix-action#287
laminas/laminas-ci-matrix-action#286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants