Fix Incorrect globbing of docs directory during linting checks #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, the problem here is not the tool path - The problem is the expansion of the command argument in the shell. Currently, the job receives markdownlint docs/book/**/*.mdwhere what it actually needs is markdownlint 'docs/book/**/*.md' |
|
So the tool is doing globbing internally? I do not see why would it not work with shell expansions. Number of arguments it can handle I guess? Good catch. |
gsteel
changed the title
markdownlint-cli2
|
I should probably rebase onto 1.27.x |
Signed-off-by: George Steel <[email protected]>
|
Oh boy. Here come all the documentation lint failures again. |
Xerkus
approved these changes
Sep 10, 2024
|
Post-Release, all 123 files in laminas-validator are detected now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Markdown linting is not globbing all the files expected in the doc/book tree - perhaps the binary should be markdownlint-cli2 which is what's installed - and possibly has deps on different globbing libs that work???
Example run where 12 files are matched instead of expected 123:
https://github.com/laminas/laminas-validator/actions/runs/10796875119/job/29946873936?pr=390#step:3:286