fix: revisit AdmissionResponse of policy groups #909
+164
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavio
force-pushed
the
group-policy-revisit-admission-response
branch
from
5ea003d
to
8319169
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 63.47% 63.11% -0.36%
==========================================
Files 17 17
Lines 1043 1052 +9
==========================================
+ Hits 662 664 +2
- Misses 381 388 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
flavio
force-pushed
the
group-policy-revisit-admission-response
branch
from
8319169
to
7324377
Compare
fabriziosestito
approved these changes
Sep 19, 2024
|
Overall LGTM, some integration tests are failing due to the updated |
The API Server puts some limitations on the warnings: - they cannot exceed 256 characters - the size of all the warnings cannot exceed 4096 characters - they are returned as HTTP headers, hence not all characters are allowed Because of these reasons, starting from now, we use the warning struct only to tell the user whether a member policy was evaluated or not. When it was evaluated we just tell the outcome (allow/reject). The details of each policy evaluation are returned as part of the `AdmissionResponse.status.details.causes`. Notes: the warning messages are always shown, regardless of the request being accepted or rejected. The `AdmissionResponse.status.details.causes` are shown only when the request is rejected. `kubectl` shows them only when run with verbose major or equal to 4 (`-v4`). Policy Server always shows the `causes` inside of its logs when running in `debug` mode. The `causes` are always sent as part of the traces emitted by Policy Server. Signed-off-by: Flavio Castelli <[email protected]>
flavio
force-pushed
the
group-policy-revisit-admission-response
branch
from
7324377
to
445a710
Compare
|
everything should be green now, I'll merge the PR once everything passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API Server puts some limitations on the warnings:
Because of these reasons, starting from now, we use the warning struct only to tell the user whether a member policy was evaluated or not. When it was evaluated we just tell the outcome (allow/reject).
The details of each policy evaluation are returned as part of the
AdmissionResponse.status.details.causes.Notes: the warning messages are always shown, regardless of the request being accepted or rejected.
The
AdmissionResponse.status.details.causesare shown only when the request is rejected.kubectlshows them only when run with verbose major or equal to 4 (-v4).Policy Server always shows the
causesinside of its logs when running indebugmode.The
causesare always sent as part of the traces emitted by Policy Server.