Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow external NATS #701

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: allow external NATS #701

wants to merge 3 commits into from
+33 −23

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Jan 2, 2024 •
edited
Loading

Pull request description

  • Allow passing external NATS details even when nats.enabled: false (so the NATS server is not deployed)
  • Allow passing external NATS server with nats.uri

Fixes

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

vsukhin
vsukhin approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @ypoplavs please confirm

@ypoplavs
Copy link
Contributor

ypoplavs commented Jan 9, 2024

hey @rangoo94! Thanks for the PR! Could you please re-create it to go into develop branch first?

@frederikb
Copy link
Contributor

@rangoo94 @vsukhin Hey, this in would be quite helpful to. Is there anything blocking it (except for rebasing against develop) from getting released? Thanks a lot!

And seeing that the NATS configuration was removed from the testkube-operator values file: am I correct in assuming that it was never intended to be included there and that the operator does not interact with NATS?

@seanuleh
Copy link

seanuleh commented Sep 3, 2024

bump on this, any chance of this getting merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

@exu exu Awaiting requested review from exu

@nicufk nicufk Awaiting requested review from nicufk

@ypoplavs ypoplavs Awaiting requested review from ypoplavs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rangoo94 @ypoplavs @frederikb @seanuleh @vsukhin