Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4832: Asynchronous preemption in the scheduler #4833

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sanposhiho
Copy link
Member

  • One-line PR description: Add KEP-4832.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Sep 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanposhiho
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 7, 2024
@sanposhiho
Copy link
Member Author

/cc @alculquicondor @Huang-Wei @mengqiy

@sanposhiho
Copy link
Member Author

/cc @hakuna-matatah

@alculquicondor
Copy link
Member

cc @macsko @dom4ha

@sanposhiho sanposhiho changed the title KEP-4832: Asynchronous PostFilter KEP-4832: Asynchronous preemption in the scheduler Sep 10, 2024
@@ -0,0 +1,3 @@
kep-number: 4832
alpha:
approver: "@wojtek-t"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @wojtek-t

🙏

@dom4ha
Copy link

dom4ha commented Sep 17, 2024

Moving the discussion from kubernetes/kubernetes#125491 (comment). I'm mainly concerned that making preemption API calls async will be replaced with setting nominatedNodeName, which IIUC is also an API call (the reservation has to be visible for autoscaler, so cannot be just within the scheduler cache, which I think is assumed in this KEP).

Is it a valid concern? If yes, then calling AddNominatedPod (setting nominatedNodeName) async as well maybe could help. I'm not suggesting adding new extension point here though.

@sanposhiho
Copy link
Member Author

sanposhiho commented Sep 17, 2024

making preemption API calls async will be replaced with setting nominatedNodeName, which IIUC is also an API call

Setting nominatedNodeName requires API call, but we won't do that at PostFilter. We will only do AddNominatedPod, which doesn't make any API calls since it just modifies the cache. And any actual API calls for the pod deletion and setting nominatedNodeName will be done asynchronously. That's what this KEP proposes.

the reservation has to be visible for autoscaler, so cannot be just within the scheduler cache

The reservation has to be visible once the preemption (= actual pod deletion) is done because otherwise CA would make incorrect decision with the preemption target nodes, which is likely low-utilized just after the preemption.
In other words, not need until then, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

4 participants