-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4832: Asynchronous preemption in the scheduler #4833
base: master
Are you sure you want to change the base?
Conversation
sanposhiho
commented
Sep 7, 2024
- One-line PR description: Add KEP-4832.
- Issue link: Asynchronous preemption in the scheduler #4832
- Other comments:
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanposhiho The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
df7c1a0
to
7204c57
Compare
/cc @hakuna-matatah |
6c24651
to
a0d192c
Compare
a0d192c
to
058dfeb
Compare
@@ -0,0 +1,3 @@ | |||
kep-number: 4832 | |||
alpha: | |||
approver: "@wojtek-t" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @wojtek-t
🙏
Moving the discussion from kubernetes/kubernetes#125491 (comment). I'm mainly concerned that making preemption API calls async will be replaced with setting nominatedNodeName, which IIUC is also an API call (the reservation has to be visible for autoscaler, so cannot be just within the scheduler cache, which I think is assumed in this KEP). Is it a valid concern? If yes, then calling AddNominatedPod (setting nominatedNodeName) async as well maybe could help. I'm not suggesting adding new extension point here though. |
Setting nominatedNodeName requires API call, but we won't do that at PostFilter. We will only do
The reservation has to be visible once the preemption (= actual pod deletion) is done because otherwise CA would make incorrect decision with the preemption target nodes, which is likely low-utilized just after the preemption. |