Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4786: Direct cgroup stats collection on Node #4787

Closed
wants to merge 0 commits into from
Closed

KEP-4786: Direct cgroup stats collection on Node #4787

wants to merge 0 commits into from

Conversation

linxiulei
Copy link

  • One-line PR description: Direct cgroup stats collection on Node
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2024
@linxiulei linxiulei mentioned this pull request Aug 12, 2024
Open
4 tasks
@linxiulei linxiulei force-pushed the master branch 2 times, most recently from 3c58dfe to 71ee6d2 Compare August 12, 2024 16:17
SergeyKanzhelev
SergeyKanzhelev reviewed Aug 12, 2024
View reviewed changes
keps/sig-node/4786-direct-cgroup-stats-collection/README.md Outdated
[#18044]: https://github.com/kubernetes/kubernetes/issues/18044
[#124520]: https://github.com/kubernetes/kubernetes/pull/124520

### Goals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this work related: kubernetes/kubernetes#107960?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems related. Added.

SergeyKanzhelev
SergeyKanzhelev reviewed Aug 12, 2024
View reviewed changes
keps/sig-node/4786-direct-cgroup-stats-collection/README.md Outdated

## Proposal

This KEP only involves changes in Kubelet so it's trivial to move logic from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the overhead reduction will come from? Can you please add details?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added details, PTAL!

@ffromani
Copy link
Contributor

There's a proposal floating about getting the stats from the container runtime, but I don't remember the details atm

@linxiulei linxiulei closed this Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: linxiulei

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 19, 2024
@linxiulei
Copy link
Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@linxiulei: Failed to re-open PR: state cannot be changed. There are no new commits on the linxiulei:master branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linxiulei
Copy link
Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@linxiulei: Failed to re-open PR: state cannot be changed. There are no new commits on the linxiulei:master branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linxiulei
Copy link
Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@linxiulei: Failed to re-open PR: state cannot be changed. There are no new commits on the linxiulei:master branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linxiulei
Copy link
Author

reopen

@linxiulei
Copy link
Author

hmm, can't reopen it so had to create a new PR #4792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node PR Triage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linxiulei @ffromani @k8s-ci-robot @SergeyKanzhelev