Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable injecting middlewares into the Firebase API client #187

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Enable injecting middlewares into the Firebase API client #187

merged 2 commits into from
Jun 26, 2023

Conversation

l-alexandrov
Copy link
Contributor

Description

It makes possible adding a Guzzle middleware to the Guzzle HTTP client. This feature was recently introduced in the SDK in version 7.3.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #187 (5d680bf) into main (ff02dbd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #187      +/-   ##
============================================
+ Coverage     98.38%   98.41%   +0.02%     
- Complexity       46       47       +1     
============================================
  Files             3        3              
  Lines           124      126       +2     
============================================
+ Hits            122      124       +2     
  Misses            2        2              
Impacted Files Coverage Δ
src/FirebaseProjectManager.php 96.87% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jeromegamez jeromegamez changed the title Guzzle middleware configuration option Enable injecting middlewares into the Firebase API client Jun 26, 2023
@jeromegamez jeromegamez merged commit 9579a07 into kreait:main Jun 26, 2023
7 checks passed
@jeromegamez
Copy link
Member

Thanks! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants