chore: update cross-domain-utils to typescript version #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregjopa
reviewed
Mar 8, 2023
| @@ -7,7 +7,7 @@ import { | |||
| assertSameDomain, | |||
| type SameDomainWindowType, | |||
| type CrossDomainWindowType, | |||
| } from "@krakenjs/cross-domain-utils/src"; | |||
| } from "@krakenjs/cross-domain-utils/dist/esm"; | |||
There was a problem hiding this comment.
This is really awesome to see! I really like how dist/esm provides the vanilla JS code for other deps to use while still supporting the existing tree shaking/dead code elimination strategy.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 40.62% 40.62%
=======================================
Files 13 13
Lines 1290 1290
=======================================
Hits 524 524
Misses 766 766 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.