Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerInfo functionality #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

PlayerInfo functionality #1

wants to merge 11 commits into from

Conversation

kunalpowar
Copy link

  • also added a few glogs to enable debugging

type A2SPlayerRequest struct {
}

func (A2SPlayerRequest) MarshalBinaryFromChallenge(c ChallengeResponse) ([]byte) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the A2SPlayerRequest should be instantiated with the ChallengeResponse, and not passed to this method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get the marshalBinary part. But Why should A2SPlayerRequest know Challenge Response. It is built using a challenge Response. The request itself need not have the challenge as a separate entity. In fact the first implementation had something like

type A2SPlayerRequest struct {
c ChallengeResponse
}

@kidoman
Copy link
Owner

kidoman commented Jun 9, 2014

thanks for the PR. we definitely needed this

  • the glog changes to the existing code should be a separate PR
  • a lot of things are wrong with the code in the PR, please have a look

@kunalpowar
Copy link
Author

Thanks for the feedback. Am still in progress of cleaning up the code. Will solve the issues you pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants