Simplify meson.build #206
Simplify meson.build #206
Conversation
| parson_shared_lib = shared_library( | ||
| meson.project_name(), | ||
| sources: parson_sources, | ||
| soversion: lib_so_version, | ||
| install: true | ||
| ) | ||
|
|
||
| parson_static_lib = static_library( | ||
| parson_lib = library( | ||
| meson.project_name(), | ||
| sources: parson_sources, | ||
| install: true | ||
| ) |
There was a problem hiding this comment.
library(), like shared_library(), accepts the soversion argument -- it is used only when building the shared component. Was this intentionally dropped?
Aside: just noticed in commit da126c2 the project version was added as the library soversion.
But in #179 (comment) it was predicted that there shouldn't really be breaking ABI changes between versions... and the soversion was set to "0" here.
Which one is it? (The cmake one seems wrong to me, since it says the ABI is broken every time PARSON_VERSION is updated.)
There was a problem hiding this comment.
Yes, SOVERSION in cmake doesn't seem to make sense but at this point I don't know if removing it might break something.
I don't use or know meson and cmake so I'm open to PRs fixing those issues.
This pull request makes the meson.build more compact. If a user would like a static library they will pass -Ddefault_library=static to build one instead of making both a static and shared lib.