Upgrade to Rails v7.2 #843
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezekg
commented
May 17, 2024
ezekg
commented
May 17, 2024
| module ActiveRecordWhereAssoc | ||
| module ActiveRecordCompat | ||
| if ActiveRecord.gem_version >= Gem::Version.new('7.2.0.alpha') | ||
| def self.normalize_association_name(name) = name.to_sym |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
from
b38eb80
to
69a27f3
Compare
ezekg
commented
May 17, 2024
ezekg
commented
May 17, 2024
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
3 times, most recently
from
953d70a
to
91fb970
Compare
ezekg
commented
May 18, 2024
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
from
91fb970
to
aeab923
Compare
ezekg
commented
May 20, 2024
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
2 times, most recently
from
b497cd1
to
af37a86
Compare
|
I give up. I tried various workarounds for rails/rails#51853, but I think this is a bug that needs to be fixed upstream. |
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
from
af37a86
to
6f7ef50
Compare
|
@ezekg Are you willing to try and bisect with your repro script to help identify the cause of the change? |
@zzak Sure. I posted the bisect results in rails/rails#51853 (comment). |
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
2 times, most recently
from
6ac3a00
to
3f9713f
Compare
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
from
3f9713f
to
cd38c21
Compare
|
I think failing tests are related to the export/import tests missing: before { Sidekiq::Testing.inline! }
after { Sidekiq::Testing.fake! } |
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
from
cd38c21
to
82431af
Compare
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
2 times, most recently
from
c317123
to
a1b2fea
Compare
ezekg
force-pushed
the
feature/upgrade-rails-7-2
branch
from
a1b2fea
to
322ca46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Using the current release candidate.
Bullet doesn't support Rails v7.2 yet.