Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement function to clear all ssh-agent identities #10649

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

AlexpFr
Copy link
Contributor

@AlexpFr AlexpFr commented May 1, 2024

Implement a function that replicates the behavior of the ssh-add -D command.

image

Testing strategy

Tested manually and compare result to the real ssh-add -D command.
Ensure that the Tools menu item is hidden when the SSH agent is disabled or when -DWITH_XC_SSHAGENT=OFF.

Type of change

  • ✅ New feature (change that adds functionality)

@AlexpFr AlexpFr changed the title Feature/ssh agent ssh add d Implement function to clear all ssh-agent identities May 1, 2024
@AlexpFr AlexpFr force-pushed the feature/sshAgent-ssh-add-D branch 4 times, most recently from 5d43dba to d38d502 Compare May 7, 2024 19:07
@AlexpFr
Copy link
Contributor Author

AlexpFr commented May 25, 2024

Hello, is this PR ready for a merge? Do I need to review certain points?
Thanks.

@droidmonkey
Copy link
Member

Will review when I get the chance

@AlexpFr AlexpFr force-pushed the feature/sshAgent-ssh-add-D branch from d38d502 to f232411 Compare June 23, 2024 20:43
@droidmonkey droidmonkey requested a review from hifi June 23, 2024 20:49
@AlexpFr AlexpFr force-pushed the feature/sshAgent-ssh-add-D branch from f232411 to ee37774 Compare June 23, 2024 20:54
@AlexpFr
Copy link
Contributor Author

AlexpFr commented Jun 23, 2024

Remember note:

Openssh-portable upstream code relative to ssh-add -D:

@AlexpFr AlexpFr force-pushed the feature/sshAgent-ssh-add-D branch from ee37774 to ba7b42f Compare June 30, 2024 09:23
@droidmonkey droidmonkey modified the milestones: v2.8.0, v2.7.10 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all keepass ssh keys without locking db
2 participants