Micro optimization for softmax_forward_kernel5
#762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes a micro-optimization for
softmax_forward_kernel5
.Summary
use
warpReduceMax
inattention_forward.cu
to use__shfl_down_sync
to be consistent with the other kernels (reduce to all threads in a warp)micro optimization for
softmax_forward_kernel5
Compared to the original code, the with this optimization gain improvements (left: original code, right: modified code):
tests done:
output from modified code
Output from the original code
output from
./attention_forward