QUnit Adding Contribute ribbon link. #218
Conversation
Tossing my hat in the ring on a good way to display this. Corner ribbons were favored, so I went with that.
…into QUnit-add-contribute-link
There were comments that the ribbon was a bit too large, so this is shrinking it a bit.
Moving to using an anchor for the ribbon instead of "jacky" javascripting.
|
This looks pretty good. There's still sizes at which the ribbon overlaps with small parts of the footer, but that might be harmless enough to ignore it. Since the ribbon itself is pretty light on information about its purpose, how about adding a title attribute with something like "Report issues or contribute improvements on GitHub"? |
|
About the ribbon overlapping footer, I have a few suggestion for each width range:
|
|
If we still need to make it smaller, a slight-change-idea is to make it very minimal, but grow on hover. |
|
👍 on @jzaefferer's title idea. One more suggestion: PS: Once we define it, we could poke @ajpiano. He is a good person for those suggestions. |
|
Closing due to inactivity. I'd really like to see us move forward with a solution for #279, but this seems to have stalled. |
Attempting to fix #189.