Skip to content

Commit

Permalink
chromedriver flags that make ci happy eveywhere
Browse files Browse the repository at this point in the history
  • Loading branch information
dten authored and jonhoo committed Jul 15, 2024
1 parent 0d1f067 commit a10e6fc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
5 changes: 2 additions & 3 deletions ci/windows-latest-chrome.ps1
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
npm i puppeteer
# pin to 125 due to https://issues.chromium.org/issues/42323434
npx @puppeteer/browsers install chrome@125
npx @puppeteer/browsers install chromedriver@125
npx @puppeteer/browsers install chrome@stable
npx @puppeteer/browsers install chromedriver@stable
Start-Process -FilePath chromedriver
Start-Sleep -Seconds 1
3 changes: 0 additions & 3 deletions tests/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ pub fn make_capabilities(s: &str) -> map::Map<String, serde_json::Value> {
"args": [
"--headless",
"--disable-gpu",
"--no-sandbox",
"--disable-dev-shm-usage",
// https://issues.chromium.org/issues/42323434
"--remote-debugging-pipe"
],
});
caps.insert("goog:chromeOptions".to_string(), opts);
Expand Down

0 comments on commit a10e6fc

Please sign in to comment.