fix(xmpp): Fixes skipping messages when disco-info is processed late. #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using bosh and xmpp conference-request (no jiconop on server-side) we can drop av moderation and speaker-stats messages.
saghul
previously approved these changes
Sep 4, 2024
| @@ -508,8 +514,9 @@ export default class XMPP extends Listenable { | |||
| this._maybeSendDeploymentInfoStat(true); | |||
|
|
|||
| if (this._components.length > 0) { | |||
There was a problem hiding this comment.
Drop the if since it's always initialized to an array?
There was a problem hiding this comment.
@saghul Why do we want to drop the if? Technically we don't check only if it is array but also if we have added components in it, right? It seems still valid to me.
There was a problem hiding this comment.
By default components is empty and we will iterate over the messages and don't do anything. So its not a big deal with the check ...
There was a problem hiding this comment.
I understand that functionally it wont change anything. I'm asking technically what is the advantage to iterate over the messages and call the function so that it will quickly exit versus just having the check?
saghul
previously approved these changes
Sep 4, 2024
jallamsetty1
previously approved these changes
Sep 4, 2024
hristoterezov
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using bosh and xmpp conference-request (no jiconop on server-side) we can drop av moderation and speaker-stats messages.