feat(statistics) remove AudioOutputProblemDetector #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been broken for over 3 years now, since jitsi@ca325f5#diff-9e19da30f465ca5665ac3d7ca1aa03d0498aed1be0cb2d7eeb27684a2636da77 Ever since that change, the "audioLevelReportHistory" property is not populated, so it justs acts on nothing an generates bogus log lines such as: ``` [modules/statistics/AudioOutputProblemDetector.js] A potential problem is detected with the audio output for participant b5fb30bc, local audio levels: [null,null], remote audio levels: undefined ``` Since nobody seems to have noticed in 3 years it's safe to assume we don't need this at all, so it gets the axe treatment.
|
Good catch @saghul! We have moved away from getting audio levels from |
jallamsetty1
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been broken for over 3 years now, since ca325f5#diff-9e19da30f465ca5665ac3d7ca1aa03d0498aed1be0cb2d7eeb27684a2636da77
Ever since that change, the "audioLevelReportHistory" property is not populated, so it justs acts on nothing an generates bogus log lines such as:
Since nobody seems to have noticed in 3 years it's safe to assume we don't need this at all, so it gets the axe treatment.