New Codec selection logic #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct the codecs. Allow asymmetric codecs to be configured on the endpoints. This means that Firefox and Safari which have bugs with VP9 encode will now encode VP8 but decode VP9 coming in from Chromium endpoints.
|
Jenkins test this please. |
On participant join/leave, check if the new intersection of codecs are already configured to be the top n codecs.
jallamsetty1
force-pushed
the
feat-multiple-codecs
branch
from
09a1c5f
to
86a8853
Compare
|
Failure seems to be a bridge issue where the bridge stops sending media to p2. |
saghul
previously approved these changes
Jun 27, 2023
…-lines. Also, ignore remote codecs published in presence for p2p connections.
Fix an issue where p2p between mobile and desktop was broken.
saghul
requested changes
Jun 30, 2023
Munge the initial offer sent out by RN clients since RN doesn't support RTCRtpTransceiver#setCodecPreferences.
saghul
approved these changes
Jul 3, 2023
|
LGTM, awesome work! Can you pl give it a go on mobile to make sure everything is a-ok? |
nils-ohlmeier
pushed a commit
to nils-ohlmeier/lib-jitsi-meet
that referenced
this pull request
Jul 10, 2023
* fix(codec-selection) Use a configurable preferred codecs list to select the codecs. Allow asymmetric codecs to be configured on the endpoints. This means that Firefox and Safari which have bugs with VP9 encode will now encode VP8 but decode VP9 coming in from Chromium endpoints. * fix(codec-selection) Add unit tests for the codec selection logic. * feat(codec-selection): Introduce mobileCodecPreferenceOrder setting in config.js. * fix(codec-selection) Avoid unnecessary renegotiations. On participant join/leave, check if the new intersection of codecs are already configured to be the top n codecs. * Address review comments * fix: Strip the codecs that are not in the codec list from the video m-lines. Also, ignore remote codecs published in presence for p2p connections. * fix: Define default codec order for mobile and desktop. Fix an issue where p2p between mobile and desktop was broken. * fix: Add default codecs for both p2p and jvb on mobile devices. Munge the initial offer sent out by RN clients since RN doesn't support RTCRtpTransceiver#setCodecPreferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a configurable preferred codecs list to select the codecs.
Allow asymmetric codecs to be configured on the endpoints. This means that Firefox and Safari which have bugs with VP9 encode will now encode VP8 but decode VP9 coming in from Chromium endpoints.