Add tests for chunking module #4
Merged
+191
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guenthermi
reviewed
Sep 17, 2024
There was a problem hiding this comment.
The tests look already good, but it would be nice to have something more explicitly. For example some text snippets and the expected boundaries.
For the modifications to the chunking. Probably we need to clean this up a bit further, I want to get rid of all the default values
violenil
force-pushed
the
test-chunking
branch
from
6d7e7d5
to
b1d7b54
Compare
guenthermi
approved these changes
Sep 20, 2024
chunked_pooling/chunking.py
Outdated
| text, | ||
| return_offsets_mapping=True, | ||
| add_special_tokens=False, | ||
| max_length=512, |
There was a problem hiding this comment.
is this correct to set max-length=512?
There was a problem hiding this comment.
I can probably remove this.
run_chunked_eval.py
Outdated
| @@ -104,7 +99,6 @@ def main(model_name, strategy, task_name, eval_split): | |||
| output_folder='results-normal-pooling', | |||
| eval_splits=[eval_split], | |||
| overwrite_results=True, | |||
| batch_size=BATCH_SIZE, | |||
There was a problem hiding this comment.
I think this should not be remove as here is another batch size argument:
I know it is a bit messy ...
There was a problem hiding this comment.
that's annoying, but OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some more tests to the chunking methods, and adds back the semantic chunking logic.