Remove time travel ralted testcase

Signed-off-by: Enwei Jiao <[email protected]>
jiaoew1991 · Aug 9, 2023 · 040e7f6 · 040e7f6
1 parent e13b6b8
commit 040e7f6
Show file tree

Hide file tree

Showing 30 changed files with 263 additions and 1,585 deletions.
diff --git a/internal/core/src/segcore/SegmentInterface.cpp b/internal/core/src/segcore/SegmentInterface.cpp
@@ -64,11 +64,10 @@ SegmentInternalInterface::FillTargetEntry(const query::Plan* plan,
 std::unique_ptr<SearchResult>
 SegmentInternalInterface::Search(
     const query::Plan* plan,
-    const query::PlaceholderGroup* placeholder_group,
-    Timestamp timestamp) const {
+    const query::PlaceholderGroup* placeholder_group) const {
     std::shared_lock lck(mutex_);
     check_search(plan);
-    query::ExecPlanNodeVisitor visitor(*this, timestamp, placeholder_group);
+    query::ExecPlanNodeVisitor visitor(*this, 1L << 63, placeholder_group);
     auto results = std::make_unique<SearchResult>();
     *results = visitor.get_moved_result(*plan->plan_node_);
     results->segment_ = (void*)this;

diff --git a/internal/core/src/segcore/SegmentInterface.h b/internal/core/src/segcore/SegmentInterface.h
@@ -49,8 +49,7 @@ class SegmentInterface {
 
     virtual std::unique_ptr<SearchResult>
     Search(const query::Plan* Plan,
-           const query::PlaceholderGroup* placeholder_group,
-           Timestamp timestamp) const = 0;
+           const query::PlaceholderGroup* placeholder_group) const = 0;
 
     virtual std::unique_ptr<proto::segcore::RetrieveResults>
     Retrieve(const query::RetrievePlan* Plan, Timestamp timestamp) const = 0;
@@ -119,8 +118,7 @@ class SegmentInternalInterface : public SegmentInterface {
 
     std::unique_ptr<SearchResult>
     Search(const query::Plan* Plan,
-           const query::PlaceholderGroup* placeholder_group,
-           Timestamp timestamp) const override;
+           const query::PlaceholderGroup* placeholder_group) const override;
 
     void
     FillPrimaryKeys(const query::Plan* plan,

diff --git a/internal/core/src/segcore/segment_c.cpp b/internal/core/src/segcore/segment_c.cpp
@@ -70,7 +70,6 @@ Search(CSegmentInterface c_segment,
        CSearchPlan c_plan,
        CPlaceholderGroup c_placeholder_group,
        CTraceContext c_trace,
-       uint64_t timestamp,
        CSearchResult* result) {
     try {
         auto segment = (milvus::segcore::SegmentInterface*)c_segment;
@@ -82,7 +81,7 @@ Search(CSegmentInterface c_segment,
 
         auto span = milvus::tracer::StartSpan("SegcoreSearch", &ctx);
 
-        auto search_result = segment->Search(plan, phg_ptr, timestamp);
+        auto search_result = segment->Search(plan, phg_ptr);
         if (!milvus::PositivelyRelated(
                 plan->plan_node_->search_info_.metric_type_)) {
             for (auto& dis : search_result->distances_) {

diff --git a/internal/core/src/segcore/segment_c.h b/internal/core/src/segcore/segment_c.h
@@ -43,7 +43,6 @@ Search(CSegmentInterface c_segment,
        CSearchPlan c_plan,
        CPlaceholderGroup c_placeholder_group,
        CTraceContext c_trace,
-       uint64_t timestamp,
        CSearchResult* result);
 
 void

diff --git a/internal/core/unittest/bench/bench_search.cpp b/internal/core/unittest/bench/bench_search.cpp
@@ -90,10 +90,8 @@ Search_GrowingIndex(benchmark::State& state) {
                     dataset_.timestamps_.data(),
                     dataset_.raw_);
 
-    Timestamp time = 10000000;
-
     for (auto _ : state) {
-        auto qr = segment->Search(plan.get(), ph_group.get(), time);
+        auto qr = segment->Search(plan.get(), ph_group.get());
     }
 }
 
@@ -125,9 +123,8 @@ Search_Sealed(benchmark::State& state) {
         segment->DropFieldData(milvus::FieldId(100));
         segment->LoadIndex(info);
     }
-    Timestamp time = 10000000;
     for (auto _ : state) {
-        auto qr = segment->Search(plan.get(), ph_group.get(), time);
+        auto qr = segment->Search(plan.get(), ph_group.get());
     }
 }