Config: handle dns_canonicalize_hostname=fallback setting #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann-soubeyrand
force-pushed
the
v9
branch
2 times, most recently
from
3945082
to
dd9155a
Compare
The major version subdirectory seems to be necessary only to support legacy projects not using Go modules. These projects should be rare as of today.
Co-authored-by: Jonathan Turner <[email protected]>
limit the number of iterations when a zero string is provided on 32-bit systems to maxInt32 rather than 2^32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds support for the
dns_canonicalize_hostname=fallbacksetting, but it’s a breaking change. I saw that there already is acandidateV9branch, but it doesn’t seem to be up to date with the latest v8 changes. I find it difficult to maintain several major versions using subdirectories instead of branches. I understand that it was a way to maintain backward compatibility for people not using Go modules, however it seems that Go modules have done their way and it may not be relevant anymore. That’s why I started this new branch where I put the v8 at the root of the repository and then cherry-picked your v9 changes on top of it before adding my commit. What do you think?