New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in case of one line realm configuration #448

Open

obatysh wants to merge 1 commit into jcmturner:master from obatysh:parse_realm_fix

obatysh commented Sep 9, 2021

We had a panic problem parsing a config with one line realm configuration, like:
[realms]
ATHENA.MIT.EDU = { kdc = kerberos.mit.edu }

panic: runtime error: slice bounds out of range [1:0]
in config.parseRealms

The following change fixes the panic problem.


          Fix panic in case of one line realm configuration

ff959ff

jcmturner force-pushed the parse_realm_fix branch from ddd1854 to ff959ff Compare

June 14, 2022 16:49

Owner

jcmturner commented Jul 14, 2022

Thanks for the PR. Some observations I have...

Is the one line configuration actually invalid or should krb5conf handle parsing it? I'm not sure but we should check that out.
Which ever way we handle this a unit test is needed to cover the case.
If we decide that erroring is the right handling we should use an error message that guides the user to why the parsing failed so they can correct the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet