Fix #75 - Bug with form submit handler not being attached in some cases #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the HTML5 spec, the 'form' property of an HTMLInputElement may be any id of a form in the current document *or* the containing form HTMLFormElement itself. The second case was previously not accounted for, only adding the submit handler when a string was present. This was breaking functionality on IE9. Credit for this goes to @littletijn: http://git.io/vRYQX
|
Works for me! |
|
@littletijn No problem! Thanks for finding the issue. 😃 @jamesallardice Is there anything preventing this from being merged? We've been using this 'patched' version internally across a few sites without any ill-effect. |
DragorWW
added a commit
to DragorWW/Placeholders.js
that referenced
this pull request
Sep 27, 2016
- add tast to build - add code from commit jamesallardice#99
|
I rebuild your code and update grunt to v 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MDN, the
formproperty of an HTMLInputElement may be the id of any form in the current document or the containing form HTMLFormElement itself.The second case was previously not accounted for, only adding the submit handler when a string was present. This was breaking functionality on IE9.
All credit for this goes to @littletijn: http://git.io/vRYQX only submitting this myself as they have not responded to the issue, and (s)he doesn't look to be active.
Fixes #75