Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jaeger] Jaeger allInOne allow different storage types #603

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rgaduput
Copy link
Contributor

@rgaduput rgaduput commented Sep 19, 2024

What this PR does

Allow different storage backend type for allInOne than just memory/badger.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format,
will close that issue when PR gets merged)

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • [] README.md has been updated to match version/contain new values

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, lgtm

@pavelnikolov
Copy link
Contributor

@rgaduput merging is blocked because the commits are not GPG signed. Could you, please, GPG-sign the commits?

@rgaduput
Copy link
Contributor Author

@rgaduput merging is blocked because the commits are not GPG signed. Could you, please, GPG-sign the commits?

@pavelnikolov fixed it, please check.

@pavelnikolov pavelnikolov merged commit 29a0e21 into jaegertracing:main Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants