Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyring debugging and error handling, support darwin/arm64 #147

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Keyring debugging and error handling, support darwin/arm64 #147

merged 4 commits into from
Jun 29, 2023

Commits on Jun 28, 2023

  1. Enable Keyring debugging in verbose mode 

    This will log details about the available backends, the chosen backend, and other Keyring things.
    @simpson-ross
    simpson-ross committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    bb1802d View commit details
    Browse the repository at this point in the history

  2. Exit with error is the keyring can't be opened 

    Same as done in `exec.go`
    @simpson-ross
    simpson-ross committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    fceac03 View commit details
    Browse the repository at this point in the history

  3. Detect and throw an error if the creds can't be set in the Keyring 

    Currently an error when setting the item misleadingly results in the success message.  There's nothing in the Keyring docs about this (`Set` doesn't return an error), but I've found that `nil` is returned when the call is successful, and an error is returned otherwise.

Unsure if this is good Golang practice or not.
    @simpson-ross
    simpson-ross committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    988642d View commit details
    Browse the repository at this point in the history

  4. Adds darwin/arm64 as a build target 

    Also adds `$GOARCH` to the the build paths, since there are two darwin targets now (otherwise one would overwrite the other).
    @simpson-ross
    simpson-ross committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    314aa8f View commit details
    Browse the repository at this point in the history