-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 51 adding form components #101
Conversation
The search form does need some logic for calculating the current available options. Should we use some debounce logic to reduce computation? const debounce = (func: (...args: any[]) => any, timeout: number = 500) => {
let timer: number;
return (...args: any[]) => {
clearTimeout(timer);
timer = setTimeout(() => {
func.apply(this, args);
}, timeout);
};
}; I don't like such logic inside the component, as it is a very specific use case. But if this form is used with a big list of available options - this is a problem which should be addressed. |
some forms are missing ... |
We should introduce a composable to define unique id's automagically to every html element. Ussage like the following:
vuetify uses similiar approach with some vue methods to generate the unique id's. |
|
Above comment suggestions were done in this commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one small edition when testing out the components: I can select a radio button by clicking on the text, but for the checkbox-component I can only select it by clicking into the box itself. I think clicking the text should also select it.
🎉 This PR is included in version 1.11.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.12.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issues #51