Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump master to next version #15555

Closed
wants to merge 7 commits into from
Closed

Bump master to next version #15555

wants to merge 7 commits into from

Conversation

howardjohn
Copy link
Member

Description

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@howardjohn howardjohn requested review from a team as code owners August 15, 2024 00:07
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 15, 2024
@craigbox
Copy link
Contributor

craigbox commented Aug 15, 2024

http://localhost:5610/news/releases/1.5.x/announcing-1.5/
  [404] http://localhost:5610/docs/reference/config/istio.operator.v1alpha1/
ERROR: Detected 1 broken links

istio/api#3286
istio/istio#52472

I'll edit the reference to the file for now, but we may want to have it added back to the generated documentation as part of the cleanup when we remove the operator docs.

/retest

@ericvn
Copy link
Contributor

ericvn commented Aug 15, 2024

profile-demo failed in tasks/traffic-management/egress/egress-kubernetes-services/test.sh with:

VERIFY FAILED snip_kubernetes_externalname_service_to_access_an_external_service_5 (timeout after 120s):
received:
"{
  "headers": {
    "Accept": "*/*",
    "Host": "my-httpbin.default.svc.cluster.local",
    "User-Agent": "curl/8.9.1",
    "X-Amzn-Trace-Id": "Root=1-66bd55fa-79bf71927c81f03109f35b4e",
    "X-Envoy-Attempt-Count": "1",
    "X-Envoy-Peer-Metadata": "ChoKCkNMVVNURVJfSUQSDBoKS3ViZXJuZXRlcwp5CgZMQUJFTFMSbyptCg4KA2FwcBIHGgVzbGVlcAoqCh9zZXJ2aWNlLmlzdGlvLmlvL2Nhbm9uaWNhbC1uYW1lEgcaBXNsZWVwCi8KI3NlcnZpY2UuaXN0aW8uaW8vY2Fub25pY2FsLXJldmlzaW9uEggaBmxhdGVzdAofCgROQU1FEhcaFXNsZWVwLTk0NTRjYzQ3Ni05cDZucQoWCglOQU1FU1BBQ0USCRoHZGVmYXVsdApJCgVPV05FUhJAGj5rdWJlcm5ldGVzOi8vYXBpcy9hcHBzL3YxL25hbWVzcGFjZXMvZGVmYXVsdC9kZXBsb3ltZW50cy9zbGVlcAqKAwoRUExBVEZPUk1fTUVUQURBVEES9AIq8QIKPwoQZ2NwX2djZV9pbnN0YW5jZRIrGilna2UtcHJvdy1pc3Rpby10ZXN0LXBvb2wtZTItMTJkM2UzMTUtY2JiMgosChNnY3BfZ2NlX2luc3RhbmNlX2lkEhUaEzU1NDMyOTI4OTkzNTYxMTExNzkKHgoUZ2NwX2drZV9jbHVzdGVyX25hbWUSBhoEcHJvdwp5ChNnY3BfZ2tlX2NsdXN0ZXJfdXJsEmIaYGh0dHBzOi8vY29udGFpbmVyLmdvb2dsZWFwaXMuY29tL3YxL3Byb2plY3RzL2lzdGlvLXByb3ctYnVpbGQvbG9jYXRpb25zL3VzLXdlc3QxLWEvY2x1c3RlcnMvcHJvdwocCgxnY3BfbG9jYXRpb24SDBoKdXMtd2VzdDEtYQohCgtnY3BfcHJvamVjdBISGhBpc3Rpby1wcm93LWJ1aWxkCiQKEmdjcF9wcm9qZWN0X251bWJlchIOGgw1NjA0MjczNzQwNjQKGAoNV09SS0xPQURfTkFNRRIHGgVzbGVlcA==",
    "X-Envoy-Peer-Metadata-Id": "sidecar~10.244.0.77~sleep-9454cc476-9p6nq.default~default.svc.cluster.local"
  }
}"
expected:
""X-Envoy-Decorator-Operation": "my-httpbin.default.svc.cluster.local:80/*""

@ericvn
Copy link
Contributor

ericvn commented Aug 15, 2024

profile default failed in tasks/security/authorization/authz-ingress/gtwapi_test.sh and tasks/security/authorization/authz-tcp/test.sh with

authorizationpolicy.security.istio.io/ingress-policy created
Error: unknown flag: --for
Failed distribution of authorizationpolicy ingress-policy in namespace istio-system
NAME                                                    CLUSTER        CDS             LDS             EDS             RDS             ECDS        ISTIOD                      VERSION
httpbin-d6d5dd865-ks49b.foo                             Kubernetes     SYNCED (1s)     SYNCED (0s)     SYNCED (0s)     SYNCED (1s)     IGNORED     istiod-64c94ccc58-tc9xq     1.24-alpha.2021e0ebd4b65592c62522236f3c3823da18fd0c
istio-eastwestgateway-7458b45754-b799w.istio-system     Kubernetes     SYNCED (0s)     SYNCED (0s)     SYNCED (0s)     IGNORED         IGNORED     istiod-64c94ccc58-tc9xq     1.24-alpha.2021e0ebd4b65592c62522236f3c3823da18fd0c
istio-egressgateway-6db86bf67b-5dw8w.istio-system       Kubernetes     SYNCED (0s)     SYNCED (0s)     SYNCED (0s)     IGNORED         IGNORED     istiod-64c94ccc58-tc9xq     1.24-alpha.2021e0ebd4b65592c62522236f3c3823da18fd0c
istio-ingressgateway-69ff559b5-z9mj2.istio-system       Kubernetes     SYNCED (0s)     SYNCED (0s)     SYNCED (0s)     SYNCED (0s)     IGNORED     istiod-64c94ccc58-tc9xq     1.24-alpha.2021e0ebd4b65592c62522236f3c3823da18fd0c
TEST: wait for failed, but continuing.
Duration: 0 seconds
authorizationpolicy.security.istio.io/ingress-policy configured
....

and

No resources found
VERIFY FAILED snip_before_you_begin_4 (timeout after 120s):
received:
"connection rejected"
expected:
"hello port 9002
connection succeeded"

@ericvn
Copy link
Contributor

ericvn commented Aug 15, 2024

/test doc.test.profile-demo

@ericvn
Copy link
Contributor

ericvn commented Aug 15, 2024

/test doc.test.profile-default

@ericvn
Copy link
Contributor

ericvn commented Aug 15, 2024

And profile-none failed in setup/install/operator/test.sh which makes sense:

Creating test debug file: /logs/artifacts/tests-setup-profile-none-aadb8f/TestDocs/setup/install/operator/test.sh/test.sh/_test_context/test.sh_debug.txt
Error: unknown command "operator" for "istioctl"
Run 'istioctl --help' for usage.

@craigbox
Copy link
Contributor

Sigh, now I can't directly commit to your branch due to branch protection rules.

tasks/traffic-management/egress/egress-kubernetes-services: I changed the header it was looking for from X-Envoy-Decorator-Operation to X-Envoy-Peer-Metadata because the former doesn't seem to be added if you don't have tracing enabled, and the point is just to show some Envoy header.

@istio-testing
Copy link
Contributor

istio-testing commented Aug 16, 2024

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
gencheck_istio.io 0a8dccc link true /test gencheck
lint_istio.io 0a8dccc link true /test lint
doc.test.profile-default_istio.io 0a8dccc link true /test doc.test.profile-default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@craigbox
Copy link
Contributor

craigbox commented Aug 19, 2024

  • gencheck: easy
  • lint: failing on the operator install doc, just put that back and delete the test file for now and I'll fix up the deprecation in another PR
  • authz-tcp: authz-tcp doctest flake #15505
  • authz-ingress: looks to be a flake related to timing now we've removed istioctl x wait. An auth policy is set to target a Gateway, then the logs of the gateway are grepped to find the remoteIP value, which is put into $CLIENT_IP. It hasn't propagated by the time the logs are queried.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Aug 20, 2024
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@howardjohn
Copy link
Member Author

moved to #15595

@howardjohn howardjohn closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants