Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute code in blocking mode by default #1233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Apr 22, 2024

This fixes jupyter-client's test_signal_kernel_subprocesses.
shell_is_blocking=True is now set by default when executing code. A kernel running in async mode should override with shell_is_blocking=False and shell_is_awaiting=True.

@davidbrochart davidbrochart marked this pull request as draft April 22, 2024 17:29
@davidbrochart davidbrochart changed the title Raise KeyboardInterrupt when handling SIGINT by default Execute code in blocking mode by default Apr 22, 2024
@davidbrochart davidbrochart marked this pull request as ready for review April 22, 2024 21:51
Copy link
Collaborator

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've manually confirmed that this does indeed fix some of the downstream jupyter_client test failures.

@davidbrochart davidbrochart enabled auto-merge (squash) May 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants