Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transceiver getter to downtrack #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aalekseevx
Copy link

Transceiver getter adds more flexibility to downtrack API, e.g. track Mid can be retrieved from downtrack. Also, transceiver setter is already present.

@aalekseevx aalekseevx changed the title fead: add transceiver getter to downtrack feat: add transceiver getter to downtrack Dec 17, 2022
@aalekseevx
Copy link
Author

@grahamking, Hi! Thanks for the review, are there any blockers for merging?

@grahamking
Copy link
Contributor

grahamking commented Apr 7, 2023

At least 1 approving review is required by reviewers with write access

The project moved from the pion org, which I am part of, to 'ionorg', which I am not, so I can't approve it. And the 'ionorg' member list is not public, so 🤷‍♂️ not sure what to do here. @ojroques maybe you can review?

@grahamking
Copy link
Contributor

I also suspect the golangci-lint check is broken, has been broken for a while, so you may not be able to merge even with a review.

This project might be abandoned. Maybe ask in the Pion Slack?

@ojroques
Copy link
Contributor

ojroques commented Apr 7, 2023

I'm not part of the organization either. I can't help sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants