Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to suggest running a git fetch and branch cleanup #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

C-Howard
Copy link

@C-Howard C-Howard commented Aug 15, 2024

This pr is an attempt to document the post merge work / branch cleanup. I made my best attempt to write valid documentation, I am not personally setup to run emacs on my computer. I attempted to use documentation and examples of formatting in the README now to try to get it as right as possible. This is a bit of a rough draft as I made have missed some important information.

Closes #55

@C-Howard C-Howard marked this pull request as ready for review August 15, 2024 01:50
#+begin_comment
Yes #uselessuseofcat but it is clearer than < > ! # $) &&*!&♨±⌘︎ to newbies.
#+end_comment

You are also recommended to fetch all git remotes in new repository to update your local state.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand this part--the script just did a full fetch, there should be no new changes incoming after running the script. After a while, yes, but not after you just merged. Does this actually change something for you?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

tomono/tomono

Line 64 in 4ca8975

git fetch --atomic "$reponame"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it I am also confused why this step seems to be required. It should have fetched all the objects for the origins as part of the merging process and in theory should be up to date. As part of my personal testing the origins have not actually changed during the merge process either. I can however confirm it is the most likely cause of issues such as #21. My best guess is that the git repo thinks it is out of sync with the remotes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems to be specific to using remote repositories, if you use full git paths instead of local paths you can replicate the issues trying to rebase merged branches. I believe it should be easy to replicate but I can attempt to make some reproduction steps as well.

Your repos list has to use the full git urls such as the usage example. It seems like there are subtle differences in behavior between what happens when you use the full url vs merge local repositories such as your test scripts.

$ cat my-repos.txt
[email protected]:mycompany/my-repo-abc.git  abc
[email protected]:mycompany/my-repo-def.git  def
[email protected]:mycompany/my-lib-uuu.git   uuu  lib/uuu
[email protected]:mycompany/my-lib-zzz.git   zzz  lib/zzz
https://gitee.com/shijie/zhongguo.git     中国

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What To Do With Merged Branches
2 participants