Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom format documentation #91

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

merlinz01
Copy link
Contributor

Fix the documentation to reflect more accurately how the format specifiers for individual parts are output: without the 0x prefix.

Copy link
Owner

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you. I'm not going to ship a new release for this just yet, though. With the extra format specifiers - though I'm adding support for \n (recommended), but I'll keep {nl} support and document it still (might remove it from docs later but keep support) - I started working on migrating from the 3 format control options to just a list of formats. I want to release a preview with that and will migrate setting. I want to ship that soon, but if it waits too long I'll ship a patch release with just this. I think people will figure it out and fix it in the short term.

@heaths heaths merged commit 1b8a9c1 into heaths:main Feb 9, 2024
8 checks passed
@merlinz01 merlinz01 deleted the fix-custom-format-documentation branch February 9, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants