Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: hide client count nav link when chrooted listener #28346

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Sep 10, 2024

Description

Follow-on to #28036. There is undesirable behavior when accessing the client count dashboard within a chrooted listener, so this PR removes the nav item to client counts when the GUI is accessed on a chrooted listener.

Here is the sidenav as a root user logged into a chrooted listener:
Screenshot 2024-09-10 at 17 09 13

  • Ent tests pass

@hashishaw hashishaw added this to the 1.18.0-rc milestone Sep 10, 2024
@hashishaw hashishaw requested a review from a team as a code owner September 10, 2024 21:58
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 10, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw merged commit abdeda4 into main Sep 11, 2024
45 of 48 checks passed
@hashishaw hashishaw deleted the ui/VAULT-30825/hide-cc-in-chroot branch September 11, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants