-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release notes and knowns issues for aws auth external id bug #28129
Conversation
CI Results: |
Build Results: |
@@ -0,0 +1,14 @@ | |||
### AWS Auth Role configuration requires an external_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### AWS Auth Role configuration requires an external_id | |
### AWS authN role configuration requires an external ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this suggestion mean to include the capital N?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. "auth" can be ambiguous, so we include the 'N' or 'Z' to differentiate between authentication (authN) and authorization (authZ)
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since I'll be OOO and don't want to be a blocker. Please apply the last suggestion before merging
No description provided.