VAULT-28313: Consider available memory when validating samples #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancragun
added
the
changelog/bug
rebwill
approved these changes
Jun 24, 2024
ryancragun
force-pushed
the
ryan/scenario-sample-memory
branch
from
c69ef51
to
fd54f95
Compare
Further improve our sample validation by considering our available memory when determining the total number on concurrent workers to make available to our sample validator. Previously we'd only consider the number of CPU's, which could cause unreliability on machines with less memory than we'd expect. Signed-off-by: Ryan Cragun <[email protected]>
ryancragun
force-pushed
the
ryan/scenario-sample-memory
branch
from
fd54f95
to
114d3b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further improve our sample validation by considering our available memory when determining the total number of concurrent workers to make available to our sample validator.
Previously we'd only consider the number of CPU's, which could cause unreliability on machines with less memory than we'd expect.
Follow-up from our changes for scenario decoding here: #147
Checklist