Add support for .enos.vars.hcl in user's home directory #122
Conversation
jasonodonnell
added
the
changelog/feat
| func LoadHomeVarsFile() (RawFiles, error) { | ||
| rawFiles := RawFiles{} | ||
|
|
||
| home, _ := os.UserHomeDir() |
There was a problem hiding this comment.
We shouldn't swallow the error here. If $HOME (or whatever platform specific variable) isn't set we'll get and should return it and allow the caller to determine if that's a problem.
os.UserHomeDir() doesn't give us a typed error for this, so perhaps it would be best to create our own and wrap it so the caller can determine what to do.
Perhaps something like ErrHomeDirUnset.
| @@ -229,7 +230,14 @@ func readFlightPlanConfig(dir string, varFilePaths []string) (*pb.FlightPlan, er | |||
|
|
|||
| var varsFiles flightplan.RawFiles | |||
| if len(varFilePaths) == 0 { | |||
| varsFiles, err = flightplan.FindRawFiles(dir, flightplan.VariablesNamePattern) | |||
| // Check home directory first and fallback to current directory search. | |||
There was a problem hiding this comment.
We should always eval both HOME but our local files should be last writer, which lets us override things locally without making the implementation more complicated. It's been a while but I think two variables being set is okay. Though it's possible you'll get a warning diag, which I think is fine as it bubbles up where we're seeing both values.
This feature seems reasonable but I don't want to lose the ability to have local vars and common vars in a home dir. I find myself changing variables locally often and definitely don't want changing vars for one project to affect another.
There was a problem hiding this comment.
It's been a while but I think two variables being set is okay.
It seems this is not the case:
│ Error: Duplicate argument
│
│ on /Users/jasonodonnell/.enos.vars.hcl line 5:
│ 5: artifactory_username = "[email protected]"
│
│ Argument "artifactory_username" was already set at
│ /Users/jasonodonnell/Git/vault-enterprise/enos/enos.vars.hcl:5,1-21
This adds support for
$HOME/.enos.vars.hclso users can maintain a static vars file. This still supports walking the current directory for vars file, but first checks if the home file exists.Checklist