Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timing of completion to enable to configure its error message #106

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Change timing of completion to enable to configure its error message #106

merged 1 commit into from
Mar 17, 2021

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Jun 9, 2019

This pr moves completion into execute method, because the current timing is before loading config files.

This modification is needed for gulp-cli#161.

@phated
Copy link
Member

phated commented Mar 17, 2021

I believe this is breaking, since code might have assumed that execute was never run when completions were called, but otherwise looks good! I'll merge and update the commit message.

@phated phated merged commit 4cbaee6 into gulpjs:master Mar 17, 2021
@sttk
Copy link
Contributor Author

sttk commented Mar 18, 2021

@phated Thank you for merging!

@sttk sttk deleted the move_completion branch March 18, 2021 12:34
@github-actions github-actions bot mentioned this pull request Oct 18, 2021
phated pushed a commit that referenced this pull request Nov 21, 2021
phated pushed a commit that referenced this pull request Nov 21, 2021
phated pushed a commit that referenced this pull request Nov 22, 2021
phated pushed a commit that referenced this pull request Nov 22, 2021
phated pushed a commit that referenced this pull request Nov 22, 2021
phated pushed a commit that referenced this pull request Nov 22, 2021
phated pushed a commit that referenced this pull request Nov 22, 2021
This was referenced Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants