-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theming #19
Add theming #19
Conversation
Moreover, I intend multilingualization of logging by this pr.
|
@sttk do we actually want to extend this module or should we just deprecate/archive this project and make a new module? I'm not sure if a better API can be written from scratch. I kind of want to deprecate this once gulp 4.0 gets a stronger foothold so we can have people switch from |
However, I do think you came up with a really elegant solution here!! |
@phated I agree to unify gulp's logging function to What I want for customization of logging is not only coloring but also message for multilingalization or as user's favorite with emoji. I believe that many people want them. If it's ok, I'll add the same modification with this pr to |
@sttk We can make further changes to |
@phated If fancy-log or gulplog will include theming-log, I'll change gulp-cli not to use theming-log directly. I feel difficult to determine whether gulp-cli's logging function should assemble inside gulp-cli or outside. To assemble logging function into one module outside gulp-cli would make gulp-cli's code more simple. |
@sttk I don't think fancy-log should have theming. I'm going to be deprecating it in favor of gulplog once we land everything into gulp-cli (and enough people are using gulp-cli so messages don't get swallowed). |
@phated OK. I'll update gulpjs/gulp-cli#161 with new version of gulp-cli after fixing its some issues. Thanks! |
This pr enable to output themed logs by using theming-log. This will solve some issues about coloring of this module and gulp-cli.
This adds following four functions and one property:
log.themed(msg [, ...args])
log.info.themed(msg [, ...args])
log.warn.themed(msg [, ...args])
log.error.themed(msg [, ...args])
log.theme
Also, this pr enable to customize timestamp color and format by innate properties in
log.theme
.